TGC-842: Fix multilineTextField render issue#188
Merged
alexluckett merged 2 commits intomainfrom Sep 4, 2025
Merged
Conversation
|
davidjamesstone
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Bug fix
When a multilineTextField component has multiple newlines, the rendering of that output in the summary list is wrong, e.g.
Is displayed as
Ideally the rendered output in the summary list would exactly match the user's input, but
markeddoes not seem to be able to output multiple newlines. Given this limitation and the space constraints of the summary list, I think it's ok to just collapse the newlines into one and render as if the input had been:Which works fine.
Jira ticket: https://eaflood.atlassian.net/browse/TGC-842
(Description basically the same as above)
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).